Differential D8208

[backport#12573] Fix compilation when compiler do not support __builtin_clz*
ClosedPublic
Actions

Authored by majcosta on Oct 31 2020, 02:08.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCfb25120158eb: [backport#12573] Fix compilation when compiler do not support __builtin_clz*

Summary

18307849b Consensus: Fix bug when compiler do not support __builtin_clz* (532479301)

Pull request description:

#ifdef is not correct since defination is defined to 0 or 1. Should change to #if

Backport of Core PR12573

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 31 2020, 02:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2020, 02:08

majcosta requested review of this revision.Oct 31 2020, 02:08

teamcity edited the summary of this revision. (Show Details)Oct 31 2020, 02:08

Harbormaster completed remote builds in B13785: Diff 25300.Oct 31 2020, 02:16

PiRK accepted this revision.Oct 31 2020, 07:26

This revision is now accepted and ready to land.Oct 31 2020, 07:26

Closed by commit rABCfb25120158eb: [backport#12573] Fix compilation when compiler do not support __builtin_clz* (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyOct 31 2020, 20:14

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCfb25120158eb: [backport#12573] Fix compilation when compiler do not support __builtin_clz*.

Revision Contents
Changeset List

Path

Size

src/

crypto/

common.h

4 lines

Diff 25312

View Options

[backport#12573] Fix compilation when compiler do not support __builtin_clz*ClosedPublicActions