Differential D8212

[backport#12409] rpc: Reject deprecated reserveChangeKey in fundrawtransaction
ClosedPublic
Actions

Authored by majcosta on Oct 31 2020, 20:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc4a93550b018: [backport#12409] rpc: Reject deprecated reserveChangeKey in fundrawtransaction

Summary

fa5f518 rpc: Reject deprecated reserveChangeKey in fundrawtransaction (MarcoFalke)

Apparently the meaty change in this backport was already done, except
for the test.

Backport of Core PR12409

Test Plan

ninja all
test_runner.py rpc_fundrawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 31 2020, 20:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2020, 20:18

majcosta requested review of this revision.Oct 31 2020, 20:18

teamcity edited the summary of this revision. (Show Details)Oct 31 2020, 20:18

Harbormaster completed remote builds in B13790: Diff 25315.Oct 31 2020, 20:52

Was removed in v0.20.2

This revision is now accepted and ready to land.Nov 1 2020, 08:54

Closed by commit rABCc4a93550b018: [backport#12409] rpc: Reject deprecated reserveChangeKey in fundrawtransaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyNov 1 2020, 09:47

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCc4a93550b018: [backport#12409] rpc: Reject deprecated reserveChangeKey in fundrawtransaction.

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_fundrawtransaction.py

5 lines

Diff 25317

View Options

test/functional/rpc_fundrawtransaction.py

[backport#12409] rpc: Reject deprecated reserveChangeKey in fundrawtransactionClosedPublicActions