Differential D8213

[backport#12437] [Trivial] Simplify if-else blocks and more descriptive variable naming
ClosedPublic
Actions

Authored by majcosta on Oct 31 2020, 20:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC334c2a6c1e9a: [backport#12437] [Trivial] Simplify if-else blocks and more descriptive…

Summary

97bcd36811 [Trivial] Simplify if-else blocks and more descriptive variable naming (Jeff Rade)

Pull request description:

Was looking through `test_runner.py` to start work on [#11964](https://github.com/bitcoin/bitcoin/issues/11964).  Made a few changes to make the file more readable and keep these separate from future PR.

Backport of Core PR12437

Test Plan

ninja all
test_runner --extended|no parameters|list_of_tests|-x list_of_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 31 2020, 20:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2020, 20:22

majcosta requested review of this revision.Oct 31 2020, 20:22

teamcity edited the summary of this revision. (Show Details)Oct 31 2020, 20:23

Harbormaster completed remote builds in B13791: Diff 25316.Oct 31 2020, 20:57

Fabien requested changes to this revision.Nov 1 2020, 09:05

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/test_runner.py
295 ↗	(On Diff #25316)	This change just adds a new code duplication, revert
847 ↗	(On Diff #25316)	Note: https://github.com/bitcoin/bitcoin/pull/12720 Not a problem here as we enforce python 3