Page MenuHomePhabricator

Use std::vector API for construction of test data.
ClosedPublic

Authored by PiRK on Nov 2 2020, 13:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC6e8a49671a13: Use std::vector API for construction of test data.
Summary

For constructing test scripts, use std::vector and, in particular,
std::vector::insert to insert 20 zero bytes rather than listing the full
array of bytes explicitly. This makes the code easier to read and makes
it immediately obvious what the structure of the data is, without having
to count the zeros to understand it.

This is a backport of Core PR15099 and PR17254

PR17254 adds back opcodes lost in the fist PR.

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable