cli: fix -getinfo output when compiled with no wallet
ClosedPublic
Actions

Authored by PiRK on Nov 4 2020, 08:57.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCdffe4818c3e3: cli: fix -getinfo output when compiled with no wallet

Summary

Remove null wallet related fields in the output of -getinfo when compiled with no wallet.

This is a backport of Core PR17368

Test Plan

cmake .. -GNinja -DBUILD_BITCOIN_WALLET=OFF
ninja
src/bitcoind

src/bitcoin-cli -getinfo

The ouput does not show wallet specific fields, such as walletversion, balance, etc

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 4 2020, 08:57

Owners added a reviewer: Restricted Owners Package.Nov 4 2020, 08:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2020, 08:57

PiRK requested review of this revision.Nov 4 2020, 08:57

teamcity edited the summary of this revision. (Show Details)Nov 4 2020, 08:58

Harbormaster completed remote builds in B13843: Diff 25408.Nov 4 2020, 09:08

If the test plan was good, the issue won't have been inserted

This revision now requires changes to proceed.Nov 4 2020, 16:54

Test plan updated.

PiRK edited the test plan for this revision. (Show Details)Nov 4 2020, 17:11

Fabien accepted this revision.Nov 4 2020, 18:56

This revision is now accepted and ready to land.Nov 4 2020, 18:56

Closed by commit rABCdffe4818c3e3: cli: fix -getinfo output when compiled with no wallet (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyNov 4 2020, 20:18

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdffe4818c3e3: cli: fix -getinfo output when compiled with no wallet.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

2 lines

Diff 25433

View Options

cli: fix -getinfo output when compiled with no walletClosedPublicActions