Page MenuHomePhabricator
Differential D8262

test: check custom ancestor limit in mempool_packages.py
ClosedPublic
Actions

Authored by PiRK on Nov 4 2020, 14:01.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc29574b53056: test: check custom ancestor limit in mempool_packages.py
Summary

To test the custom ancestor limit on node1 (passed by the argument
-limitancestorcount), we check for three conditions:

-> the # of txs in the node1 mempool is equal to the the limit
-> all txs in node1 mempool are a subset of txs in node0 mempool
-> the node1 mempool txs match the start of the constructed tx-chain

This is a backport of Core PR17435

Test Plan

ninja && test/functional/test_runner.py mempool_packages.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 4 2020, 14:01
Owners added a reviewer: Restricted Owners Package.Nov 4 2020, 14:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2020, 14:01
PiRK requested review of this revision.Nov 4 2020, 14:01
Harbormaster completed remote builds in B13849: Diff 25417.Nov 4 2020, 14:14
majcosta requested changes to this revision.Nov 4 2020, 18:54
majcosta added a subscriber: majcosta.

this is the backport, right? https://github.com/bitcoin/bitcoin/pull/17435/files

it's missing from the summary

This revision now requires changes to proceed.Nov 4 2020, 18:54
PiRK requested review of this revision.Nov 4 2020, 19:01
PiRK edited the summary of this revision. (Show Details)

Yes, you're right. Summary fixed.

majcosta accepted this revision.Nov 4 2020, 19:23
This revision is now accepted and ready to land.Nov 4 2020, 19:23
Closed by commit rABCc29574b53056: test: check custom ancestor limit in mempool_packages.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyNov 4 2020, 20:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc29574b53056: test: check custom ancestor limit in mempool_packages.py.

Revision Contents
Changeset List

PathSize
test/
functional/
18 lines

Diff 25432

View Options

test/functional/mempool_packages.py

Loading...