Page MenuHomePhabricator
Differential D8275

refactor: Remove unused COINBASE_FLAGS
ClosedPublic
Actions

Authored by PiRK on Nov 5 2020, 09:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC09759c8f876e: refactor: Remove unused COINBASE_FLAGS
Summary

Commit d449772cf69c01932fc5d72c46054815d6300b3c stopped setting
COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.
Update the help string to remove "flags", which is not specified in
BIP 22.

One occurence of flags in the help message was already removed in D8124

This is a backport of Core PR17519

Test Plan

Verify that nothing is broken as a result of removing pushKV("flags"...
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 5 2020, 09:41
Owners added a reviewer: Restricted Owners Package.Nov 5 2020, 09:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2020, 09:42
PiRK requested review of this revision.Nov 5 2020, 09:42
teamcity edited the summary of this revision. (Show Details)Nov 5 2020, 09:42
Harbormaster completed remote builds in B13864: Diff 25446.Nov 5 2020, 09:45
teamcity added a comment.Nov 5 2020, 09:45
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[49/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cashaddr_tests.cpp.o
[50/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockencodings_tests.cpp.o
[51/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockstatus_tests.cpp.o
[52/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/bswap_tests.cpp.o
[53/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/bloom_tests.cpp.o
[54/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cashaddrenc_tests.cpp.o
[55/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkqueue_tests.cpp.o
[56/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkdatasig_tests.cpp.o
[57/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/compilerbug_tests.cpp.o
[58/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/config_tests.cpp.o
[59/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/core_io_tests.cpp.o
[60/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/compress_tests.cpp.o
[61/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/coins_tests.cpp.o
[62/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dbwrapper_tests.cpp.o
[63/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cuckoocache_tests.cpp.o
[64/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/crypto_tests.cpp.o
[65/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/descriptor_tests.cpp.o
[66/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dstencode_tests.cpp.o
[67/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/excessiveblock_tests.cpp.o
[68/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/feerate_tests.cpp.o
[69/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/flatfile_tests.cpp.o
[70/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockcheck_tests.cpp.o
[71/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/inv_tests.cpp.o
[72/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/getarg_tests.cpp.o
[73/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/fs_tests.cpp.o
[74/412] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o
[75/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/hash_tests.cpp.o
[76/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkle_tests.cpp.o
[77/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkpoints_tests.cpp.o
[78/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockfilter_index_tests.cpp.o
[79/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkleblock_tests.cpp.o
[80/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/mempool_tests.cpp.o
[81/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/monolith_opcodes_tests.cpp.o
[82/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/multisig_tests.cpp.o
[83/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o
FAILED: src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-8;-warnings-as-errors=*" --source=../../src/test/miner_tests.cpp -- /usr/bin/clang++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/univalue/include -I../../src/. -Isrc -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -g -O2 -fPIE -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wshadow -Wshadow-field -Wrange-loop-analysis -Wredundant-decls -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -MF src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o.d -o src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -c ../../src/test/miner_tests.cpp
/work/abc-ci-builds/build-clang-tidy/../../src/test/miner_tests.cpp:258:18: error: use of undeclared identifier 'COINBASE_FLAGS' [clang-diagnostic-error]
                 COINBASE_FLAGS));
                 ^
2775 warnings and 1 error generated.
Error while processing /work/abc-ci-builds/build-clang-tidy/../../src/test/miner_tests.cpp.
Suppressed 2775 warnings (2775 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[84/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/net_tests.cpp.o
[85/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/ref_tests.cpp.o
[86/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/op_reversebytes_tests.cpp.o
[87/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/pmt_tests.cpp.o
[88/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/prevector_tests.cpp.o
[89/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/radix_tests.cpp.o
[90/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/policyestimator_tests.cpp.o
[91/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rcu_tests.cpp.o
[92/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/finalization_tests.cpp.o
[93/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/reverselock_tests.cpp.o
[94/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/denialofservice_tests.cpp.o
[95/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/interfaces_tests.cpp.o
[96/412] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/netbase_tests.cpp.o
ninja: build stopped: subcommand failed.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Nov 5 2020, 09:45
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[57/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockcheck_tests.cpp.o
[58/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockfilter_tests.cpp.o
[59/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/core_io_tests.cpp.o
[60/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockstatus_tests.cpp.o
[61/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockfilter_index_tests.cpp.o
[62/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cashaddr_tests.cpp.o
[63/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/compilerbug_tests.cpp.o
[64/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkdatasig_tests.cpp.o
[65/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkpoints_tests.cpp.o
[66/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/compress_tests.cpp.o
[67/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cashaddrenc_tests.cpp.o
[68/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/config_tests.cpp.o
[69/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkqueue_tests.cpp.o
[70/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/fs_tests.cpp.o
[71/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/coins_tests.cpp.o
[72/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dstencode_tests.cpp.o
[73/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/feerate_tests.cpp.o
[74/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cuckoocache_tests.cpp.o
[75/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/excessiveblock_tests.cpp.o
[76/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkle_tests.cpp.o
[77/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/crypto_tests.cpp.o
[78/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dbwrapper_tests.cpp.o
[79/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/flatfile_tests.cpp.o
[80/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/descriptor_tests.cpp.o
[81/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/inv_tests.cpp.o
[82/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkleblock_tests.cpp.o
[83/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/denialofservice_tests.cpp.o
[84/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/multisig_tests.cpp.o
[85/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/finalization_tests.cpp.o
[86/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/net_tests.cpp.o
[87/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/netbase_tests.cpp.o
[88/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/pmt_tests.cpp.o
[89/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/hash_tests.cpp.o
[90/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/ref_tests.cpp.o
[91/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rcu_tests.cpp.o
[92/419] Linking CXX executable src/pow/test/test-pow
[93/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/getarg_tests.cpp.o
[94/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/interfaces_tests.cpp.o
[95/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o
FAILED: src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o 
/usr/bin/ccache /usr/bin/clang++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/univalue/include -I../../src/. -Isrc -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIE -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wshadow -Wshadow-field -Wrange-loop-analysis -Wredundant-decls -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -MF src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o.d -o src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -c ../../src/test/miner_tests.cpp
../../src/test/miner_tests.cpp:258:18: error: use of undeclared identifier 'COINBASE_FLAGS'
                 COINBASE_FLAGS));
                 ^
1 error generated.
[96/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/policyestimator_tests.cpp.o
[97/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/prevector_tests.cpp.o
[98/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/reverselock_tests.cpp.o
[99/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/op_reversebytes_tests.cpp.o
[100/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/sanity_tests.cpp.o
[101/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/monolith_opcodes_tests.cpp.o
[102/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rpc_server_tests.cpp.o
[103/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rwcollection_tests.cpp.o
[104/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/scheduler_tests.cpp.o
[105/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/radix_tests.cpp.o
[106/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rpc_tests.cpp.o
[107/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/mempool_tests.cpp.o
[108/419] secp256k1: testing secp256k1-tests
ninja: build stopped: subcommand failed.
Build build-clang failed with exit code 1
teamcity added a comment.Nov 5 2020, 09:47
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[134/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/config_tests.cpp.o
[135/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/core_io_tests.cpp.o
[136/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/crypto_tests.cpp.o
[137/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dbwrapper_tests.cpp.o
[138/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/descriptor_tests.cpp.o
[139/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockencodings_tests.cpp.o
[140/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/addrman_tests.cpp.o
[141/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockfilter_index_tests.cpp.o
[142/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/feerate_tests.cpp.o
[143/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/flatfile_tests.cpp.o
[144/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cashaddr_tests.cpp.o
[145/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/arith_uint256_tests.cpp.o
[146/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/inv_tests.cpp.o
[147/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/mempool_tests.cpp.o
[148/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/compress_tests.cpp.o
[149/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkpoints_tests.cpp.o
[150/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dstencode_tests.cpp.o
[151/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkdatasig_tests.cpp.o
[152/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/multisig_tests.cpp.o
[153/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/fs_tests.cpp.o
[154/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/excessiveblock_tests.cpp.o
[155/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/monolith_opcodes_tests.cpp.o
[156/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/netbase_tests.cpp.o
[157/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/op_reversebytes_tests.cpp.o
[158/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/hash_tests.cpp.o
[159/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/finalization_tests.cpp.o
[160/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/denialofservice_tests.cpp.o
[161/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/getarg_tests.cpp.o
[162/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/prevector_tests.cpp.o
[163/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/radix_tests.cpp.o
[164/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rcu_tests.cpp.o
[165/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rpc_server_tests.cpp.o
[166/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rpc_tests.cpp.o
[167/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/scheduler_tests.cpp.o
[168/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o
FAILED: src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/univalue/include -I../../src/. -Isrc -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIE -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -MF src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o.d -o src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -c ../../src/test/miner_tests.cpp
In file included from /usr/include/boost/test/test_tools.hpp:45,
                 from /usr/include/boost/test/unit_test.hpp:18,
                 from ../../src/test/miner_tests.cpp:27:
../../src/test/miner_tests.cpp: In function ‘void miner_tests::TestCoinbaseMessageEB(uint64_t, std::__cxx11::string, const CTxMemPool&)’:
../../src/test/miner_tests.cpp:258:18: error: ‘COINBASE_FLAGS’ was not declared in this scope
                  COINBASE_FLAGS));
                  ^~~~~~~~~~~~~~
../../src/test/miner_tests.cpp:258:18: note: suggested alternative: ‘EAI_BADFLAGS’
[169/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/interfaces_tests.cpp.o
[170/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/sanity_tests.cpp.o
[171/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkle_tests.cpp.o
[172/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/ref_tests.cpp.o
[173/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/schnorr_tests.cpp.o
[174/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkleblock_tests.cpp.o
[175/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/pmt_tests.cpp.o
[176/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/policyestimator_tests.cpp.o
[177/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/reverselock_tests.cpp.o
[178/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/net_tests.cpp.o
[179/738] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rwcollection_tests.cpp.o
[180/738] secp256k1: testing secp256k1-tests
[181/738] leveldb: testing db_test
ninja: build stopped: subcommand failed.
Build build-diff failed with exit code 1
teamcity added a comment.Nov 5 2020, 09:49
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[57/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cashaddr_tests.cpp.o
[58/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkdatasig_tests.cpp.o
[59/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cashaddrenc_tests.cpp.o
[60/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/bloom_tests.cpp.o
[61/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/blockfilter_index_tests.cpp.o
[62/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkpoints_tests.cpp.o
[63/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/checkqueue_tests.cpp.o
[64/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/config_tests.cpp.o
[65/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/compilerbug_tests.cpp.o
[66/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/compress_tests.cpp.o
[67/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/core_io_tests.cpp.o
[68/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/crypto_tests.cpp.o
[69/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/coins_tests.cpp.o
[70/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dbwrapper_tests.cpp.o
[71/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/cuckoocache_tests.cpp.o
[72/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/dstencode_tests.cpp.o
[73/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/descriptor_tests.cpp.o
[74/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/inv_tests.cpp.o
[75/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/feerate_tests.cpp.o
[76/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/fs_tests.cpp.o
[77/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/flatfile_tests.cpp.o
[78/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/excessiveblock_tests.cpp.o
[79/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/hash_tests.cpp.o
[80/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/finalization_tests.cpp.o
[81/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/getarg_tests.cpp.o
[82/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/denialofservice_tests.cpp.o
[83/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkleblock_tests.cpp.o
[84/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/merkle_tests.cpp.o
[85/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/pmt_tests.cpp.o
[86/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/op_reversebytes_tests.cpp.o
[87/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/prevector_tests.cpp.o
[88/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/netbase_tests.cpp.o
[89/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/interfaces_tests.cpp.o
[90/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/monolith_opcodes_tests.cpp.o
[91/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o
FAILED: src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/univalue/include -I../../src/. -Isrc -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIE -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -MF src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o.d -o src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -c ../../src/test/miner_tests.cpp
In file included from /usr/include/boost/test/test_tools.hpp:45,
                 from /usr/include/boost/test/unit_test.hpp:18,
                 from ../../src/test/miner_tests.cpp:27:
../../src/test/miner_tests.cpp: In function ‘void miner_tests::TestCoinbaseMessageEB(uint64_t, std::__cxx11::string, const CTxMemPool&)’:
../../src/test/miner_tests.cpp:258:18: error: ‘COINBASE_FLAGS’ was not declared in this scope
                  COINBASE_FLAGS));
                  ^~~~~~~~~~~~~~
../../src/test/miner_tests.cpp:258:18: note: suggested alternative: ‘EAI_BADFLAGS’
[92/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/multisig_tests.cpp.o
[93/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/mempool_tests.cpp.o
[94/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/policyestimator_tests.cpp.o
[95/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/net_tests.cpp.o
[96/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/ref_tests.cpp.o
[97/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/reverselock_tests.cpp.o
[98/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/sanity_tests.cpp.o
[99/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/radix_tests.cpp.o
[100/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rwcollection_tests.cpp.o
[101/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rcu_tests.cpp.o
[102/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rpc_server_tests.cpp.o
[103/420] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/rpc_tests.cpp.o
[104/420] secp256k1: testing secp256k1-tests
ninja: build stopped: subcommand failed.
Build build-debug failed with exit code 1
PiRK edited the summary of this revision. (Show Details)Nov 5 2020, 09:49

I submitted too fast, sorry. Working on the test issue.

teamcity added a comment.Nov 5 2020, 09:51
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

tool_wallet.py                                   | ○ Skipped | 0 s
wallet_abandonconflict.py                        | ○ Skipped | 0 s
wallet_address_types.py                          | ○ Skipped | 0 s
wallet_avoidreuse.py                             | ○ Skipped | 0 s
wallet_backup.py                                 | ○ Skipped | 0 s
wallet_balance.py                                | ○ Skipped | 0 s
wallet_basic.py                                  | ○ Skipped | 0 s
wallet_coinbase_category.py                      | ○ Skipped | 0 s
wallet_create_tx.py                              | ○ Skipped | 0 s
wallet_createwallet.py                           | ○ Skipped | 0 s
wallet_createwallet.py --usecli                  | ○ Skipped | 0 s
wallet_dump.py                                   | ○ Skipped | 0 s
wallet_encryption.py                             | ○ Skipped | 0 s
wallet_groups.py                                 | ○ Skipped | 0 s
wallet_hd.py                                     | ○ Skipped | 0 s
wallet_import_rescan.py                          | ○ Skipped | 0 s
wallet_import_with_label.py                      | ○ Skipped | 0 s
wallet_importmulti.py                            | ○ Skipped | 0 s
wallet_importprunedfunds.py                      | ○ Skipped | 0 s
wallet_keypool.py                                | ○ Skipped | 0 s
wallet_keypool_topup.py                          | ○ Skipped | 0 s
wallet_labels.py                                 | ○ Skipped | 0 s
wallet_listreceivedby.py                         | ○ Skipped | 0 s
wallet_listsinceblock.py                         | ○ Skipped | 0 s
wallet_listtransactions.py                       | ○ Skipped | 0 s
wallet_multiwallet.py                            | ○ Skipped | 0 s
wallet_reorgsrestore.py                          | ○ Skipped | 0 s
wallet_resendwallettransactions.py               | ○ Skipped | 0 s
wallet_txn_clone.py                              | ○ Skipped | 0 s
wallet_txn_clone.py --mineblock                  | ○ Skipped | 0 s
wallet_txn_doublespend.py                        | ○ Skipped | 0 s
wallet_txn_doublespend.py --mineblock            | ○ Skipped | 0 s
wallet_watchonly.py                              | ○ Skipped | 0 s
wallet_watchonly.py --usecli                     | ○ Skipped | 0 s
wallet_zapwallettxes.py                          | ○ Skipped | 0 s

ALL                                              | ✓ Passed  | 300 s (accumulated) 
Runtime: 60 s

[102/383] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[113/383] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o
FAILED: src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/univalue/include -I../../src/. -Isrc -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIE -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -MF src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o.d -o src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o -c ../../src/test/miner_tests.cpp
In file included from /usr/include/boost/test/test_tools.hpp:45,
                 from /usr/include/boost/test/unit_test.hpp:18,
                 from ../../src/test/miner_tests.cpp:27:
../../src/test/miner_tests.cpp: In function ‘void miner_tests::TestCoinbaseMessageEB(uint64_t, std::__cxx11::string, const CTxMemPool&)’:
../../src/test/miner_tests.cpp:258:18: error: ‘COINBASE_FLAGS’ was not declared in this scope
                  COINBASE_FLAGS));
                  ^~~~~~~~~~~~~~
../../src/test/miner_tests.cpp:258:18: note: suggested alternative: ‘EAI_BADFLAGS’
[125/383] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/transaction_tests.cpp.o
ninja: build stopped: subcommand failed.
Build build-without-wallet failed with exit code 1
PiRK updated this revision to Diff 25448.Nov 5 2020, 10:06

fix ABC specific test (D249)

Harbormaster completed remote builds in B13866: Diff 25448.Nov 5 2020, 10:16
Fabien accepted this revision.Nov 5 2020, 10:40
This revision is now accepted and ready to land.Nov 5 2020, 10:40
Closed by commit rABC09759c8f876e: refactor: Remove unused COINBASE_FLAGS (authored by Neha Narula <narula@gmail.com>, committed by PiRK). · Explain WhyNov 5 2020, 11:59
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC09759c8f876e: refactor: Remove unused COINBASE_FLAGS.

Revision Contents
Changeset List

PathSize
src/
3 lines
rpc/
1 line
test/
3 lines
1 line
3 lines

Diff 25455

View Options

src/miner.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...