Page MenuHomePhabricator
Differential D8292

Fix lint issue in Grasberg
ClosedPublic
Actions

Authored by jasonbcox on Nov 5 2020, 19:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4ee50097bc41: Fix lint issue in Grasberg
Summary

Shifting signed 32-bit value by 31 bits is undefined behaviour
Caught by arc lint --everything

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Nov 5 2020, 19:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2020, 19:21
jasonbcox requested review of this revision.Nov 5 2020, 19:21
Harbormaster completed remote builds in B13884: Diff 25482.Nov 5 2020, 19:34
Fabien accepted this revision.Nov 5 2020, 19:51
This revision is now accepted and ready to land.Nov 5 2020, 19:51
Closed by commit rABC4ee50097bc41: Fix lint issue in Grasberg (authored by jasonbcox). · Explain WhyNov 5 2020, 20:16
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC4ee50097bc41: Fix lint issue in Grasberg.

Revision Contents
Changeset List

PathSize
src/
pow/
2 lines

Diff 25487

View Options

src/pow/grasberg.cpp

Loading...