Page MenuHomePhabricator
Differential D8300

util: remove unwanted fields from bitcoin-cli -getinfo
ClosedPublic
Actions

Authored by PiRK on Nov 6 2020, 08:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe58b64941faf: util: remove unwanted fields from bitcoin-cli -getinfo
Summary

In accordance with #17314, Removing noisy fields from -getinfo. Fields removed: protocolversion, walletversion and keypoololdest. In addition to changing bitcoin-cli -getinfo, there is another change to test/functional/interface_bitcoin_cli.py. This change deletes tests that utilize removed -getinfo calls.

Add a release note about this and also about new fields introduced in D8220/PR17302. This is extracted from Core release-notes-0.20.0.md

This is a backport of Core PR17650

Test Plan

src/bitcoin-cli -getinfo

test/functional/test_runner.py interface_bitcoin_cli.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 6 2020, 08:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2020, 08:02
PiRK requested review of this revision.Nov 6 2020, 08:02
teamcity edited the summary of this revision. (Show Details)Nov 6 2020, 08:02
PiRK updated this revision to Diff 25501.Nov 6 2020, 08:06

remove extra blank line between paragraph in release notes

PiRK edited the summary of this revision. (Show Details)Nov 6 2020, 08:14
PiRK edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B13898: Diff 25500.Nov 6 2020, 08:16
Harbormaster completed remote builds in B13899: Diff 25501.Nov 6 2020, 08:24
Fabien accepted this revision.Nov 6 2020, 14:08
This revision is now accepted and ready to land.Nov 6 2020, 14:08
Closed by commit rABCe58b64941faf: util: remove unwanted fields from bitcoin-cli -getinfo (authored by malevolent <malevolentbtc@gmail.com>, committed by PiRK). · Explain WhyNov 6 2020, 15:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe58b64941faf: util: remove unwanted fields from bitcoin-cli -getinfo.

Revision Contents
Changeset List

PathSize
doc/
10 lines
src/
6 lines
test/
functional/
6 lines

Diff 25508

View Options

doc/release-notes.md

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

test/functional/interface_bitcoin_cli.py

Loading...