ui: disable 3rd-party tx-urls when wallet disabled
ClosedPublic
Actions

Authored by PiRK on Nov 6 2020, 09:35.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC542557427be0: ui: disable 3rd-party tx-urls when wallet disabled

Summary

This PR closes #17683 by removing 3rd-party Url-Label and -TextBox from Display Options in wallet-disabled mode.

Issue 17683:

The part of the GUI that this setting is relevant for does not exist in a --disable-wallet build.

This is a backport of Core PR17694

Test Plan

src/qt/bitcoin-qt -disablewallet

In menu Settings -> Options -> Display, verify that the *Third party transaction URLs` setting is not visible.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 6 2020, 09:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2020, 09:35

PiRK requested review of this revision.Nov 6 2020, 09:35

teamcity edited the summary of this revision. (Show Details)Nov 6 2020, 09:36

Harbormaster completed remote builds in B13902: Diff 25504.Nov 6 2020, 09:46

Fabien accepted this revision.Nov 6 2020, 14:32

This revision is now accepted and ready to land.Nov 6 2020, 14:32

Closed by commit rABC542557427be0: ui: disable 3rd-party tx-urls when wallet disabled (authored by Harris <brakmic@gmail.com>, committed by PiRK). · Explain WhyNov 7 2020, 15:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC542557427be0: ui: disable 3rd-party tx-urls when wallet disabled.

Revision Contents
Changeset List

Path

Size

src/

qt/

optionsdialog.cpp

4 lines

Diff 25542

View Options

ui: disable 3rd-party tx-urls when wallet disabledClosedPublicActions