Page MenuHomePhabricator
Differential D8322

cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice
ClosedPublic
Actions

Authored by PiRK on Nov 9 2020, 10:39.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCde41d25ec5dd: cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice
Summary

If blockfilterindex=basic is specified in bitcoin.conf and again on the command line, bitcoind -chain=regtest -blockfilterindex=basic, bitcoind crashes.
This commit fixes it by replacing BlockFilterType-vector with a set of the same type to make sure that only unique filter types get inserted.

This is a backport of Core PR17687

Test Plan

After adding blockfilterindex=basic to bitcoin.conf, run:
src/bitcoind -chain=regtest -blockfilterindex=basic

Alternatively, run src/bitcoind --blockfilterindex=basic --blockfilterindex=basic

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 9 2020, 10:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2020, 10:39
PiRK requested review of this revision.Nov 9 2020, 10:39
teamcity edited the summary of this revision. (Show Details)Nov 9 2020, 10:39
majcosta requested changes to this revision.Nov 9 2020, 10:47
majcosta added a subscriber: majcosta.

PR17687*

This revision now requires changes to proceed.Nov 9 2020, 10:47
majcosta added inline comments.Nov 9 2020, 10:53
src/blockfilter.cpp
14 ↗(On Diff #25561)

this is redundant since it's included in the header file

Harbormaster completed remote builds in B13930: Diff 25561.Nov 9 2020, 10:56
PiRK edited the summary of this revision. (Show Details)Nov 9 2020, 11:05
PiRK updated this revision to Diff 25564.Nov 9 2020, 11:16

remove redundant import and fix PR number in the revision

Harbormaster completed remote builds in B13933: Diff 25564.Nov 9 2020, 11:31
majcosta accepted this revision.Nov 9 2020, 11:34
This revision is now accepted and ready to land.Nov 9 2020, 11:34
Closed by commit rABCde41d25ec5dd: cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (authored by Harris <brakmic@gmail.com>, committed by PiRK). · Explain WhyNov 9 2020, 12:10
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCde41d25ec5dd: cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice.

Revision Contents
Changeset List

PathSize
src/
3 lines
7 lines
6 lines

Diff 25565

View Options

src/blockfilter.h

Loading...
View Options

src/blockfilter.cpp

Loading...
View Options

src/init.cpp

Loading...