utils: Use _wfopen and _wreopen on Windows
ClosedPublic
Actions

Authored by PiRK on Nov 10 2020, 07:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7fa094b10e45: utils: Use _wfopen and _wreopen on Windows

Summary

The fopen function does not support unicode filename on Windows, so use Windows specific function do deal with it

This is a backport of Core PR13866

Test Plan

ninja && ninja check

Use the build bot to run tests on windows.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 10 2020, 07:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2020, 07:12

PiRK requested review of this revision.Nov 10 2020, 07:12

teamcity edited the summary of this revision. (Show Details)Nov 10 2020, 07:12

@bot build-win64

teamcity awarded a token.Nov 10 2020, 07:13

Harbormaster completed remote builds in B13956: Diff 25607.Nov 10 2020, 07:29

Fabien accepted this revision.Nov 10 2020, 09:22

This revision is now accepted and ready to land.Nov 10 2020, 09:22

Closed by commit rABC7fa094b10e45: utils: Use _wfopen and _wreopen on Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by PiRK). · Explain WhyNov 10 2020, 09:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7fa094b10e45: utils: Use _wfopen and _wreopen on Windows.

Revision Contents
Changeset List

Path

Size

src/

fs.cpp

5 lines

Diff 25616

View Options

utils: Use _wfopen and _wreopen on WindowsClosedPublicActions