Page MenuHomePhabricator
Differential D8344

Pass export privkey DER compression flag correctly
ClosedPublic
Actions

Authored by PiRK on Nov 10 2020, 07:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4af6f8885cc2: Pass export privkey DER compression flag correctly
Summary

By passing a bitfield where a boolean was expected, the result was
always compressed. Fix this.

This is a backport of Core PR14195

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 10 2020, 07:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2020, 07:33
PiRK requested review of this revision.Nov 10 2020, 07:33
teamcity edited the summary of this revision. (Show Details)Nov 10 2020, 07:33
Harbormaster completed remote builds in B13957: Diff 25608.Nov 10 2020, 07:42
PiRK added a comment.Nov 10 2020, 07:47

Looking at the discussion https://github.com/bitcoin/bitcoin/pull/10043, it seems that this does not really matter and is not used in any important piece of code. But it was still wrong and needed correction, and imho it is still a good idea to follow the upstream change.

Fabien accepted this revision.Nov 10 2020, 09:28
This revision is now accepted and ready to land.Nov 10 2020, 09:28
Closed by commit rABC4af6f8885cc2: Pass export privkey DER compression flag correctly (authored by lyjstudy, committed by PiRK). · Explain WhyNov 10 2020, 09:48
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4af6f8885cc2: Pass export privkey DER compression flag correctly.

Revision Contents
Changeset List

PathSize
src/
7 lines

Diff 25617

View Options

src/key.cpp

Loading...