test: Add cost_of_change parameter assertions to bnb_search_test
ClosedPublic
Actions

Authored by Fabien on Nov 10 2020, 12:39.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf67e38b0ef4b: test: Add cost_of_change parameter assertions to bnb_search_test

Summary

Backport of core PR18195.

Since we don't support multiplication with a double (see amount.h),
the 0.9 * CENT has been updated to 9 * CENT / 10 and so on, so the
amounts remain integers.

Test Plan

ninja check-bitcoin-coinselector_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 10 2020, 12:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2020, 12:39

Fabien requested review of this revision.Nov 10 2020, 12:39

teamcity edited the summary of this revision. (Show Details)Nov 10 2020, 12:40

Harbormaster completed remote builds in B13966: Diff 25627.Nov 10 2020, 12:52

PiRK accepted this revision.Nov 10 2020, 15:13

This revision is now accepted and ready to land.Nov 10 2020, 15:13

Closed by commit rABCf67e38b0ef4b: test: Add cost_of_change parameter assertions to bnb_search_test (authored by Yancy Ribbens <yancy.ribbens@gmail.com>, committed by Fabien). · Explain WhyNov 10 2020, 16:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf67e38b0ef4b: test: Add cost_of_change parameter assertions to bnb_search_test.

Revision Contents
Changeset List

Path

Size

src/

wallet/

test/

coinselector_tests.cpp

19 lines

Diff 25633

View Options

src/wallet/test/coinselector_tests.cpp

test: Add cost_of_change parameter assertions to bnb_search_testClosedPublicActions