Page MenuHomePhabricator
Differential D8357

test_runner: Remove unused --force option
ClosedPublic
Actions

Authored by PiRK on Nov 10 2020, 16:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC893456568d83: test_runner: Remove unused --force option
Summary

When someone calls the script they already have all intention to call it, no need to specify a redundant --force.

This is a backport of Core PR15370

Test Plan

ninja && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 10 2020, 16:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2020, 16:27
PiRK requested review of this revision.Nov 10 2020, 16:27
teamcity edited the summary of this revision. (Show Details)Nov 10 2020, 16:27
Harbormaster completed remote builds in B13970: Diff 25632.Nov 10 2020, 16:39
Fabien requested changes to this revision.Nov 10 2020, 16:42
Fabien added a subscriber: Fabien.

You're missing the documentation change which is relevant (2nd commit)

This revision now requires changes to proceed.Nov 10 2020, 16:42
PiRK updated this revision to Diff 25635.Nov 10 2020, 16:49

include second commit

Fabien accepted this revision.Nov 10 2020, 16:50
This revision is now accepted and ready to land.Nov 10 2020, 16:50
Harbormaster completed remote builds in B13972: Diff 25635.Nov 10 2020, 17:11
Closed by commit rABC893456568d83: test_runner: Remove unused --force option (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 10 2020, 17:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC893456568d83: test_runner: Remove unused --force option.

Revision Contents
Changeset List

PathSize
doc/
1 line
test/
functional/
11 lines

Diff 25641

View Options

doc/functional-tests.md

Loading...
View Options

test/functional/test_runner.py

Loading...