torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently
ClosedPublic
Actions

Authored by PiRK on Nov 11 2020, 15:06.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCc63ec5c0b09f: torcontrol: Use the default/standard network port for Tor hidden services, even…

Summary

PR description:

Currently, the hidden service is published on the same port as the public listening port.
But if a non-standard port is configured, this can be used to guess (pretty reliably) that the public IP and the hidden service are the same node.

This is a backport of Core PR15651

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 11 2020, 15:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2020, 15:06

PiRK requested review of this revision.Nov 11 2020, 15:06

teamcity edited the summary of this revision. (Show Details)Nov 11 2020, 15:06

Harbormaster completed remote builds in B13985: Diff 25654.Nov 11 2020, 15:18

majcosta accepted this revision.Nov 11 2020, 17:37

This revision is now accepted and ready to land.Nov 11 2020, 17:37

Closed by commit rABCc63ec5c0b09f: torcontrol: Use the default/standard network port for Tor hidden services, even… (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhyNov 11 2020, 19:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc63ec5c0b09f: torcontrol: Use the default/standard network port for Tor hidden services, even….

Revision Contents
Changeset List

Path

Size

src/

torcontrol.cpp

6 lines

Diff 25660

View Options

torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differentlyClosedPublicActions