Differential D8416

Implement several simple functions in DescriptorScriptPubKeyMan
ClosedPublic
Actions

Authored by deadalnix on Nov 15 2020, 01:04.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC1227eefb4e4c: Implement several simple functions in DescriptorScriptPubKeyMan

Summary

Implements a bunch of one liners: UpgradeKeyMetadata, IsFirstRun, HavePrivateKeys,
KeypoolCountExternalKeys, GetKeypoolSize, GetTimeFirstKey, CanGetAddresses,
RewriteDB

Backport of Core PR16528 [18/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/4cb9b69be031e1dc65d8964794781b347fd948f5

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 15 2020, 01:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2020, 01:04

deadalnix requested review of this revision.Nov 15 2020, 01:04

teamcity edited the summary of this revision. (Show Details)Nov 15 2020, 01:04

majcosta accepted this revision.Nov 15 2020, 01:25

This revision is now accepted and ready to land.Nov 15 2020, 01:25

Harbormaster completed remote builds in B14050: Diff 25776.Nov 15 2020, 01:27

Closed by commit rABC1227eefb4e4c: Implement several simple functions in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 15 2020, 01:55

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1227eefb4e4c: Implement several simple functions in DescriptorScriptPubKeyMan.

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.cpp

23 lines

Diff 25781

View Options

src/wallet/scriptpubkeyman.cpp

Implement several simple functions in DescriptorScriptPubKeyManClosedPublicActions