Page MenuHomePhabricator
Differential D843

Properly check for builtin
ClosedPublic
Actions

Authored by deadalnix on Dec 22 2017, 21:39.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING2a10748d48f9: Properly check for builtin
rABC2a10748d48f9: Properly check for builtin
Summary

Previously, the function to check for symbols was used, but this is wrong as builtins are not symbols.

Test Plan
cmake -GNinja ..

Check that the configure file now has the builtins set to 1.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 22 2017, 21:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2017, 21:39
Harbormaster completed remote builds in B1446: Diff 2237.Dec 22 2017, 21:39
schancel edited the summary of this revision. (Show Details)Dec 26 2017, 08:10
schancel accepted this revision.Dec 26 2017, 08:13
schancel added inline comments.
src/config/CMakeLists.txt
60 ↗(On Diff #2237)

This looks like we should put it in a cmake module?

This revision is now accepted and ready to land.Dec 26 2017, 08:13
Closed by commit rABC2a10748d48f9: Properly check for builtin (authored by deadalnix). · Explain WhyDec 26 2017, 12:44
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
config/
51 lines

Diff 2248

View Options

src/config/CMakeLists.txt

Loading...