Page MenuHomePhabricator
Differential D8436

test: Fix intermittent error in mempool_reorg
ClosedPublic
Actions

Authored by PiRK on Nov 17 2020, 13:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC4fa05d2a2a57: test: Fix intermittent error in mempool_reorg
Summary

Also speed up tx relay while touching the file anyway.

This should fix the intermittent error AssertionError: Mempool sync timed out:
If it doesn't solve the issue completely, we may also need PR17770, PR18345 and PR18704. These 3 PRs were previous unsuccesful attempts to solve this issue by Core, maybe they are useless or maybe they are part of the solution.

This is a backport of Core PR18752

Test Plan

ninja && test/functional/test_runner.py mempool_reorg

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 17 2020, 13:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2020, 13:50
PiRK requested review of this revision.Nov 17 2020, 13:50
teamcity edited the summary of this revision. (Show Details)Nov 17 2020, 13:50
Harbormaster completed remote builds in B14076: Diff 25818.Nov 17 2020, 14:03
majcosta accepted this revision.Nov 17 2020, 14:19
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/mempool_reorg.py
20 ↗(On Diff #25818)

comment on its own line

This revision is now accepted and ready to land.Nov 17 2020, 14:19
PiRK updated this revision to Diff 25820.Nov 17 2020, 14:38

address review feedback: put the comment on its own line

Harbormaster completed remote builds in B14078: Diff 25820.Nov 17 2020, 14:47
Closed by commit rABC4fa05d2a2a57: test: Fix intermittent error in mempool_reorg (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 18 2020, 10:49
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4fa05d2a2a57: test: Fix intermittent error in mempool_reorg.

Revision Contents
Changeset List

PathSize
test/
functional/
9 lines

Diff 25837

View Options

test/functional/mempool_reorg.py

Loading...