Page MenuHomePhabricator

test: Fix intermittent error in mempool_reorg
ClosedPublic

Authored by PiRK on Tue, Nov 17, 13:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC4fa05d2a2a57: test: Fix intermittent error in mempool_reorg
Summary

Also speed up tx relay while touching the file anyway.

This should fix the intermittent error AssertionError: Mempool sync timed out:
If it doesn't solve the issue completely, we may also need PR17770, PR18345 and PR18704. These 3 PRs were previous unsuccesful attempts to solve this issue by Core, maybe they are useless or maybe they are part of the solution.

This is a backport of Core PR18752

Test Plan

ninja && test/functional/test_runner.py mempool_reorg

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Tue, Nov 17, 13:50
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/mempool_reorg.py
20 ↗(On Diff #25818)

comment on its own line

This revision is now accepted and ready to land.Tue, Nov 17, 14:19

address review feedback: put the comment on its own line