Differential D8478

refactor: replace pointers by references within tx_verify.{h,cpp}
ClosedPublic
Actions

Authored by Fabien on Nov 20 2020, 14:33.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCb2effc38822e: refactor: replace pointers by references within tx_verify.{h,cpp}

Summary

affects "prevHeights" parameter of the functions
- CalculateSequenceLocks()
- SequenceLocks()

Backport of core PR19069.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 20 2020, 14:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2020, 14:34

Fabien requested review of this revision.Nov 20 2020, 14:34

teamcity edited the summary of this revision. (Show Details)Nov 20 2020, 14:34

deadalnix accepted this revision.Nov 20 2020, 14:39

This revision is now accepted and ready to land.Nov 20 2020, 14:39

Harbormaster completed remote builds in B14127: Diff 25905.Nov 20 2020, 14:45

Closed by commit rABCb2effc38822e: refactor: replace pointers by references within tx_verify.{h,cpp} (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by Fabien). · Explain WhyNov 20 2020, 15:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb2effc38822e: refactor: replace pointers by references within tx_verify.{h,cpp}.

Revision Contents
Changeset List

Path

Size

src/

consensus/

tx_verify.h

4 lines

tx_verify.cpp

10 lines

test/

miner_tests.cpp

4 lines

validation.cpp

4 lines

Diff 25906

View Options

src/consensus/tx_verify.h

View Options

src/consensus/tx_verify.cpp

View Options

src/test/miner_tests.cpp

View Options

refactor: replace pointers by references within tx_verify.{h,cpp}ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25906

src/consensus/tx_verify.h

src/consensus/tx_verify.cpp

src/test/miner_tests.cpp

src/validation.cpp

refactor: replace pointers by references within tx_verify.{h,cpp}
ClosedPublic
Actions

Revision Contents
Changeset List