Fix buildavalancheproof RPC with bitcoin-cli
ClosedPublic
Actions

Authored by Fabien on Nov 30 2020, 19:04.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC6aa3de929ec1: Fix buildavalancheproof RPC with bitcoin-cli

Summary

The sequence and expiration params need to be converted from string.

Test Plan

./src/bitcoin-cli buildavalancheproof 11 12
030b4c866585dd868a9d62348a9cd008d6a312937048fff31670e7e920cfc7a744
'[{"txid":
"12b004fff7f4b69ef8650e767f18f11ede158148b425660723b9f9a66e61f747",
"vout": 0, "amount": 10, "height": 100, "privatekey":
"030b4c866585dd868a9d62348a9cd008d6a312937048fff31670e7e920cfc7a744"}]'

Returns Invalid private key

./test/functional/test_runner.py abc_p2p_avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 30 2020, 19:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2020, 19:04

Fabien requested review of this revision.Nov 30 2020, 19:04

deadalnix accepted this revision.Nov 30 2020, 19:13

This revision is now accepted and ready to land.Nov 30 2020, 19:13

Harbormaster completed remote builds in B14247: Diff 26099.Nov 30 2020, 19:17

Closed by commit rABC6aa3de929ec1: Fix buildavalancheproof RPC with bitcoin-cli (authored by Fabien). · Explain WhyNov 30 2020, 19:41

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6aa3de929ec1: Fix buildavalancheproof RPC with bitcoin-cli.

Revision Contents
Changeset List

Path

Size

src/

rpc/

client.cpp

2 lines

Diff 26100

View Options

Fix buildavalancheproof RPC with bitcoin-cliClosedPublicActions