Differential D8603

[avalanche] Fix race condition during destruction in poll_and_response test
ClosedPublic
Actions

Authored by deadalnix on Dec 4 2020, 01:46.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC2d043eb895c0: [avalanche] Fix race condition during destruction in poll_and_response test

Summary

Previously, the Processor would be destroyed at the end of the test execution, but the callback thread would still be running, possibly calling into a destroyed Processor. To solve this problem, we move the Processor ownership to the test framework.

Test Plan

ninja all check-avalanche

Run it multiple time to ensure the race is gone.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 4 2020, 01:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2020, 01:46

deadalnix requested review of this revision.Dec 4 2020, 01:46

deadalnix mentioned this in D8552: [avalanche] Fix race condition in the destruction of the Processor.Dec 4 2020, 01:46

Harbormaster completed remote builds in B14305: Diff 26186.Dec 4 2020, 01:58

majcosta accepted this revision.Dec 4 2020, 13:00

This revision is now accepted and ready to land.Dec 4 2020, 13:00

Closed by commit rABC2d043eb895c0: [avalanche] Fix race condition during destruction in poll_and_response test (authored by deadalnix). · Explain WhyDec 4 2020, 15:23

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC2d043eb895c0: [avalanche] Fix race condition during destruction in poll_and_response test.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

386 lines

Diff 26190

View Options

src/avalanche/test/processor_tests.cpp

[avalanche] Fix race condition during destruction in poll_and_response testClosedPublicActions