Page MenuHomePhabricator
Differential D8670

Add a dumpcoins RPC to dump the coins available in the wallet
ClosedPublic
Actions

Authored by deadalnix on Dec 13 2020, 15:26.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC67df722289af: Add a dumpcoins RPC to dump the coins available in the wallet
Summary

As per title. This turned useful for debugging, so I productionized it.

Test Plan
ninja all check-all

Added a simple integration test.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 13 2020, 15:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2020, 15:26
deadalnix requested review of this revision.Dec 13 2020, 15:26
Harbormaster completed remote builds in B14400: Diff 26352.Dec 13 2020, 15:29
teamcity added a comment.Dec 13 2020, 15:30
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_wallet_dumpcoins.py ======

------- Stdout: -------
2020-12-13T15:29:14.935000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201213_152803/abc_wallet_dumpcoins_210
2020-12-13T15:29:15.192000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/abc_wallet_dumpcoins.py", line 22, in run_test
    assert_equal(node.dumpcoins(), {})
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2020-12-13T15:29:15.243000Z TestFramework (INFO): Stopping nodes
2020-12-13T15:29:15.445000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201213_152803/abc_wallet_dumpcoins_210
2020-12-13T15:29:15.445000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201213_152803/abc_wallet_dumpcoins_210/test_framework.log
2020-12-13T15:29:15.446000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201213_152803/abc_wallet_dumpcoins_210' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_wallet_dumpcoins.py

deadalnix updated this revision to Diff 26355.Dec 13 2020, 16:10

Fix no wallet build

Harbormaster completed remote builds in B14403: Diff 26355.Dec 13 2020, 16:25
majcosta requested changes to this revision.Dec 13 2020, 17:08
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/abc_wallet_dumpcoins.py
5–7 ↗(On Diff #26355)

give it an accurate description

This revision now requires changes to proceed.Dec 13 2020, 17:08
deadalnix updated this revision to Diff 26357.Dec 13 2020, 17:24

Update test comment

majcosta accepted this revision.Dec 13 2020, 17:32
This revision is now accepted and ready to land.Dec 13 2020, 17:32
Harbormaster completed remote builds in B14404: Diff 26357.Dec 13 2020, 17:50
Closed by commit rABC67df722289af: Add a dumpcoins RPC to dump the coins available in the wallet (authored by deadalnix). · Explain WhyDec 14 2020, 00:10
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC67df722289af: Add a dumpcoins RPC to dump the coins available in the wallet.

Revision Contents
Changeset List

PathSize
src/
wallet/
69 lines
test/
functional/
72 lines

Diff 26358

View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/abc_wallet_dumpcoins.py

Loading...