Qt: pass clientmodel changes from walletframe to walletviews
ClosedPublic
Actions

Authored by PiRK on Dec 22 2020, 14:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbf384a3c4786: Qt: pass clientmodel changes from walletframe to walletviews

Summary

We currently don't pass clientmodel changes from the walletframe to the walletviews leading to possible invalid access during shutdown because all walletviews miss the nullifying of the clientmodel.

This is a backport of Core PR18091

Test Plan

ninja && src/qt/bitcoin-qt -regtest
Open console
generatetoaddress(1000,getnewaddress())
Quit bitcoin-qt

Before this patch: segfault
After this patch: graceful shutdown.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 22 2020, 14:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2020, 14:18

PiRK requested review of this revision.Dec 22 2020, 14:18

teamcity edited the summary of this revision. (Show Details)Dec 22 2020, 14:18

Harbormaster completed remote builds in B14504: Diff 26525.Dec 22 2020, 14:52

Fabien accepted this revision.Dec 22 2020, 15:18

This revision is now accepted and ready to land.Dec 22 2020, 15:18

Closed by commit rABCbf384a3c4786: Qt: pass clientmodel changes from walletframe to walletviews (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by PiRK). · Explain WhyDec 22 2020, 17:28

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbf384a3c4786: Qt: pass clientmodel changes from walletframe to walletviews.

Revision Contents
Changeset List

Path

Size

src/

qt/

walletframe.cpp

5 lines

Diff 26535

View Options

Qt: pass clientmodel changes from walletframe to walletviewsClosedPublicActions