Page MenuHomePhabricator
Differential D8775

util: Fail to parse empty string in ParseMoney
ClosedPublic
Actions

Authored by PiRK on Jan 4 2021, 13:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC97abb2a88f38: util: Fail to parse empty string in ParseMoney
Summary

Remove unused ParseMoney that takes a c_str, fail to parse empty string

Supplying a fee rate or an amount on the command line as an empty string, which currently parses as 0 seems fragile and confusing.

This is a backport of Core PR18225

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 4 2021, 13:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2021, 13:57
PiRK requested review of this revision.Jan 4 2021, 13:57
teamcity edited the summary of this revision. (Show Details)Jan 4 2021, 13:58
Harbormaster completed remote builds in B14548: Diff 26602.Jan 4 2021, 14:07
Fabien accepted this revision.Jan 4 2021, 14:10
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/util/moneystr.h
24 ↗(On Diff #26602)

Fix the layout

This revision is now accepted and ready to land.Jan 4 2021, 14:10
PiRK updated this revision to Diff 26605.Jan 4 2021, 14:13

close comment on new line

Harbormaster completed remote builds in B14550: Diff 26605.Jan 4 2021, 14:39
Closed by commit rABC97abb2a88f38: util: Fail to parse empty string in ParseMoney (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 4 2021, 15:17
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC97abb2a88f38: util: Fail to parse empty string in ParseMoney.

Revision Contents
Changeset List

PathSize
src/
test/
6 lines
util/
5 lines
9 lines

Diff 26608

View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/moneystr.h

Loading...
View Options

src/util/moneystr.cpp

Loading...