Differential D8881

test: Fix restart node race
ClosedPublic
Actions

Authored by Fabien on Jan 12 2021, 13:38.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb1a28d9a77a6: test: Fix restart node race

Summary

It is not allowed to start a node before it has been fully stopped.
Otherwise it could lead to intermittent issues due to access issues
(e.g. cookie file
https://cirrus-ci.com/task/6409665024098304?command=ci#L4793)

Fix that by waiting for the node to fully stop.

I have also seen this issue on CI a few times.

Backport of core PR20683.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 12 2021, 13:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2021, 13:38

Fabien requested review of this revision.Jan 12 2021, 13:38

teamcity edited the summary of this revision. (Show Details)Jan 12 2021, 13:39

Harbormaster completed remote builds in B14717: Diff 26874.Jan 12 2021, 13:52

majcosta accepted this revision.Jan 12 2021, 13:55

This revision is now accepted and ready to land.Jan 12 2021, 13:55

Closed by commit rABCb1a28d9a77a6: test: Fix restart node race (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 12 2021, 14:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb1a28d9a77a6: test: Fix restart node race.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

3 lines

6 lines

Diff 26876

test/functional/test_framework/test_framework.py

Loading...

test/functional/test_framework/test_node.py

Loading...