Page MenuHomePhabricator
Differential D8890

util: Remove unused itostr and replace i64tostr with ToString
ClosedPublic
Actions

Authored by PiRK on Wed, Jan 13, 09:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCead7a4497d04: util: Remove unused itostr
Summary

This is a backport of Core PR18449

Test Plan
ninja all check-all
grep -R itostr ..
grep -R i64tostr ..

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK created this revision.Wed, Jan 13, 09:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 13, 09:00
PiRK requested review of this revision.Wed, Jan 13, 09:00
teamcity edited the summary of this revision. (Show Details)Wed, Jan 13, 09:00
Harbormaster completed remote builds in B14728: Diff 26896.Wed, Jan 13, 09:13
Fabien added a subscriber: Fabien.Wed, Jan 13, 10:51

@bot build-fuzzer

teamcity awarded a token.Wed, Jan 13, 10:51
Fabien accepted this revision.Wed, Jan 13, 11:15
This revision is now accepted and ready to land.Wed, Jan 13, 11:15
Closed by commit rABCead7a4497d04: util: Remove unused itostr (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyWed, Jan 13, 12:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCead7a4497d04: util: Remove unused itostr.
PiRK mentioned this in D8891: util: Replace i64tostr with ToString.Wed, Jan 13, 12:25
PiRK retitled this revision from util: Remove unused itostr to util: Remove unused itostr and replace i64tostr with ToString.
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)
Fabien mentioned this in D8908: Fix a -Wunused-variable in the locale fuzzer.Thu, Jan 14, 10:00
Fabien mentioned this in rABCf05eb5a011cb: Fix a -Wunused-variable in the locale fuzzer.Thu, Jan 14, 13:01

Revision Contents
Changeset List

PathSize
src/
rpc/
3 lines
3 lines
test/
fuzz/
4 lines
10 lines
util/
2 lines
8 lines
wallet/
3 lines

Diff 26905

View Options

src/rpc/mining.cpp

Loading...
View Options

src/sync.cpp

Loading...
View Options

src/test/fuzz/integer.cpp

Loading...
View Options

src/test/fuzz/locale.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...