Page MenuHomePhabricator

Update -blocksonly documentation
ClosedPublic

Authored by PiRK on Wed, Jan 13, 09:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd5a049238ea5: Update -blocksonly documentation
Summary

When -blocksonly is set to 1, it interacts with the -walletbroadcast
parameter and sets it to 0 if it has not been set already.This behavior
is not captured by the current documentation, which claims that -blocksonly
does not impact any wallet transactions.

Update the max number of outgoing peers from 8 to 10, due to the
addition of two -blocksonly peers.

This is a backport of Core PR18391 and PR18464

Test Plan

ninja && src/bitcoind -help

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Wed, Jan 13, 09:50
Fabien requested changes to this revision.Wed, Jan 13, 11:08
Fabien added a subscriber: Fabien.

Please also backport and squash in https://github.com/bitcoin/bitcoin/pull/18464 which is a fix for this PR.

doc/reduce-memory.md
27 ↗(On Diff #26900)

While you're at it, you can also set it to the correct value, see D8605.

doc/reduce-traffic.md
7 ↗(On Diff #26900)

Dito

This revision now requires changes to proceed.Wed, Jan 13, 11:08

squash with PR18464 and update default maximum number of connections to 4096 (D8605)

Fabien requested changes to this revision.Wed, Jan 13, 13:02
Fabien added inline comments.
doc/reduce-traffic.md
1 ↗(On Diff #26910)

Remove

8 ↗(On Diff #26910)

115 => 4086

This revision now requires changes to proceed.Wed, Jan 13, 13:02

remove accidental blank line and fix 115->4086

This revision is now accepted and ready to land.Wed, Jan 13, 14:10

rebase, to investigate a seemingly unrelated problem

When I try to land this diff with arc land-via-bot, I consistently get the following build failure during rebase operations
https://build.bitcoinabc.org/viewLog.html?buildId=178192&buildTypeId=BitcoinAbcLandBot&tab=buildLog

This revision was automatically updated to reflect the committed changes.