Page MenuHomePhabricator
Differential D8921

[backport#16380] Remove unused bits from the service flags enum
ClosedPublic
Actions

Authored by majcosta on Jan 14 2021, 17:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb051c69478dd: [backport#16380] Remove unused bits from the service flags enum
Summary

fa0d0ff6e1bee60fde63724ae28a51aac5a94d4a Remove unused bits from the service flags enum (MarcoFalke)

Pull request description:

Remove all bits that have no BIP specification nor can be observed on the active network

Backport of Core PR16380

I'm putting this up on the assumption that xthin was a BU only feature
that we can safely remove now that we don't support BCHN-chain anymore.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 14 2021, 17:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2021, 17:42
majcosta requested review of this revision.Jan 14 2021, 17:42
teamcity edited the summary of this revision. (Show Details)Jan 14 2021, 17:43
Harbormaster completed remote builds in B14782: Diff 26977.Jan 14 2021, 17:56
Fabien requested changes to this revision.Jan 15 2021, 08:32
Fabien added a subscriber: Fabien.

You're missing the message.py declaration

src/protocol.h
338 ↗(On Diff #26977)

0.22.12 ?

This revision now requires changes to proceed.Jan 15 2021, 08:32
majcosta updated this revision to Diff 26999.Jan 15 2021, 11:31

corrected date of removal and removed declaration in messages.py

Harbormaster completed remote builds in B14794: Diff 26999.Jan 15 2021, 11:43
Fabien accepted this revision.Jan 15 2021, 16:18
This revision is now accepted and ready to land.Jan 15 2021, 16:18
Closed by commit rABCb051c69478dd: [backport#16380] Remove unused bits from the service flags enum (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyJan 15 2021, 16:23
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCb051c69478dd: [backport#16380] Remove unused bits from the service flags enum.

Revision Contents
Changeset List

PathSize
src/
6 lines
2 lines
qt/
2 lines
seeder/
2 lines
test/
functional/
test_framework/
2 lines

Diff 27015

View Options

src/protocol.h

Loading...
View Options

src/protocol.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

test/functional/test_framework/messages.py

Loading...