Page MenuHomePhabricator

[backport#16380] Remove unused bits from the service flags enum
ClosedPublic

Authored by majcosta on Jan 14 2021, 17:42.

Details

Summary

fa0d0ff6e1bee60fde63724ae28a51aac5a94d4a Remove unused bits from the service flags enum (MarcoFalke)

Pull request description:

Remove all bits that have no BIP specification nor can be observed on the active network

Backport of Core PR16380

I'm putting this up on the assumption that xthin was a BU only feature
that we can safely remove now that we don't support BCHN-chain anymore.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested changes to this revision.Jan 15 2021, 08:32
Fabien added a subscriber: Fabien.

You're missing the message.py declaration

src/protocol.h
338 ↗(On Diff #26977)

0.22.12 ?

This revision now requires changes to proceed.Jan 15 2021, 08:32

corrected date of removal and removed declaration in messages.py

This revision is now accepted and ready to land.Jan 15 2021, 16:18