Page MenuHomePhabricator
Differential D8927

test: shift coverage from getunconfirmedbalance to getbalances
ClosedPublic
Actions

Authored by PiRK on Jan 15 2021, 09:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC19d226a18966: test: shift coverage from getunconfirmedbalance to getbalances
Summary

Improve getbalances coverage in wallet_balance tests
and shift some getunconfirmedbalance calls to getbalances, as the former is
deprecated, while leaving essential coverage for it in test_balances().

Shift coverage from getunconfirmedbalance to getbalances in wallet_abandonconflict tests

Use getbalances in wallet_address_types tests

This is a backport of Core PR18451

Test Plan

test/functional/test_runner.py wallet*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 15 2021, 09:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2021, 09:48
PiRK requested review of this revision.Jan 15 2021, 09:48
teamcity edited the summary of this revision. (Show Details)Jan 15 2021, 09:48
Harbormaster completed remote builds in B14792: Diff 26991.Jan 15 2021, 10:00
Fabien accepted this revision.Jan 15 2021, 10:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/wallet_balance.py
178 ↗(On Diff #26991)

Move comment above

This revision is now accepted and ready to land.Jan 15 2021, 10:25
PiRK edited the summary of this revision. (Show Details)Jan 15 2021, 11:55
PiRK edited the test plan for this revision. (Show Details)
PiRK updated this revision to Diff 27000.Jan 15 2021, 11:57

move comment on its own line

Harbormaster completed remote builds in B14795: Diff 27000.Jan 15 2021, 12:11
Closed by commit rABC19d226a18966: test: shift coverage from getunconfirmedbalance to getbalances (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyJan 15 2021, 12:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC19d226a18966: test: shift coverage from getunconfirmedbalance to getbalances.

Revision Contents
Changeset List

PathSize
test/
functional/
8 lines
11 lines
47 lines

Diff 27002

View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_address_types.py

Loading...
View Options

test/functional/wallet_balance.py

Loading...