Page MenuHomePhabricator

tests: have coins simulation test also use CCoinsViewDB
ClosedPublic

Authored by PiRK on Jan 17 2021, 09:47.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC2db657ee05bb: tests: have coins simulation test also use CCoinsViewDB
Summary

Before this change, the coins simulation test uses a base view of type
CCoinsViewTest, which has no relevance outside of the unittest suite. Might as
well reuse this testcase with a more realistic configuration that has
CCoinsViewDB at the bottom of the view structure.

This is a backport of Core PR17669

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Jan 17 2021, 09:47
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/test/coins_tests.cpp
115 ↗(On Diff #27024)
This revision is now accepted and ready to land.Jan 17 2021, 10:35

replace uint256 with BlockHash in comment