Page MenuHomePhabricator
Differential D8936

tests: have coins simulation test also use CCoinsViewDB
ClosedPublic
Actions

Authored by PiRK on Jan 17 2021, 09:47.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC2db657ee05bb: tests: have coins simulation test also use CCoinsViewDB
Summary

Before this change, the coins simulation test uses a base view of type
CCoinsViewTest, which has no relevance outside of the unittest suite. Might as
well reuse this testcase with a more realistic configuration that has
CCoinsViewDB at the bottom of the view structure.

This is a backport of Core PR17669

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 17 2021, 09:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2021, 09:47
PiRK requested review of this revision.Jan 17 2021, 09:47
teamcity edited the summary of this revision. (Show Details)Jan 17 2021, 09:47
Harbormaster completed remote builds in B14810: Diff 27024.Jan 17 2021, 09:57
majcosta accepted this revision.Jan 17 2021, 10:35
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/test/coins_tests.cpp
115 ↗(On Diff #27024)
This revision is now accepted and ready to land.Jan 17 2021, 10:35
PiRK updated this revision to Diff 27028.Jan 18 2021, 09:41

replace uint256 with BlockHash in comment

Harbormaster completed remote builds in B14814: Diff 27028.Jan 18 2021, 10:00
Closed by commit rABC2db657ee05bb: tests: have coins simulation test also use CCoinsViewDB (authored by James O'Beirne <james.obeirne@gmail.com>, committed by PiRK). · Explain WhyJan 18 2021, 16:01
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2db657ee05bb: tests: have coins simulation test also use CCoinsViewDB.

Revision Contents
Changeset List

PathSize
src/
test/
31 lines

Diff 27045

View Options

src/test/coins_tests.cpp

Loading...