Page MenuHomePhabricator
Differential D8973

script: Remove undocumented and unused operator+
ClosedPublic
Actions

Authored by PiRK on Jan 20 2021, 03:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC67d3d6330c4e: script: Remove undocumented and unused operator+
Summary

This is a backport of Core PR18612

Test Plan
ninja all check-all
ninja bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK created this revision.Jan 20 2021, 03:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2021, 03:00
PiRK requested review of this revision.Jan 20 2021, 03:00
teamcity edited the summary of this revision. (Show Details)Jan 20 2021, 03:01
Harbormaster completed remote builds in B14857: Diff 27101.Jan 20 2021, 03:15
Fabien edited the summary of this revision. (Show Details)Jan 20 2021, 08:14
Fabien requested changes to this revision.Jan 20 2021, 08:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/script/script.h
474 ↗(On Diff #27101)

That's not part of the PR

This revision now requires changes to proceed.Jan 20 2021, 08:18
PiRK updated this revision to Diff 27113.Jan 20 2021, 10:37

restore line 474 that should not have been deleted

Harbormaster completed remote builds in B14865: Diff 27113.Jan 20 2021, 10:54
Fabien accepted this revision.Jan 20 2021, 11:12
This revision is now accepted and ready to land.Jan 20 2021, 11:12
Closed by commit rABC67d3d6330c4e: script: Remove undocumented and unused operator+ (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 20 2021, 14:56
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC67d3d6330c4e: script: Remove undocumented and unused operator+.

Revision Contents
Changeset List

PathSize
src/
script/
25 lines
test/
fuzz/
12 lines
35 lines

Diff 27134

View Options

src/script/script.h

Loading...
View Options

src/test/fuzz/script_ops.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...