Page MenuHomePhabricator

test: add coverage for -rpcwallet cli option
ClosedPublic

Authored by PiRK on Jan 20 2021, 09:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCefe531436f74: test: add coverage for -rpcwallet cli option
Summary

and add -getinfo coverage with multiple wallets loaded.

The bitcoin-cli -rpcwallet= option is an essential RPC/CLI option when more than one wallet is loaded (see bitcoin-cli -help | grep -A5 rpcwallet or src/bitcoin-cli.cpp::L61) and it currently has no test coverage.

It is not only used by users, but also by the test framework and ~10 test files via get_wallet_rpc().

This PR adds coverage, while simultaneously improving the -getinfo coverage when multiple wallets are loaded.

This is a backport of Core PR18724

Test Plan

./test/functional/test_runner.py interface_bit*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.