test: use zero-argument super() shortcut (Python 3.0+)
ClosedPublic
Actions

Authored by PiRK on Jan 20 2021, 16:40.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC438dca9e5035: test: use zero-argument super() shortcut (Python 3.0+)

Summary

as defined in PEP 3135:

"The new syntax:
super()
is equivalent to:
super(__class__, <firstarg>)
where class is the class that the method was defined in, and <firstarg> is
the first parameter of the method (normally self for instance methods, and cls
for class methods)."

This is a backport of Core PR18585

Test Plan

grep "super(.*, self)" test/functional/*
ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 20 2021, 16:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2021, 16:40

PiRK requested review of this revision.Jan 20 2021, 16:40

teamcity edited the summary of this revision. (Show Details)Jan 20 2021, 16:40

revert change in feature_block

I'm not sure why the super call has the parent class as first argument, in doubt it's better to leave it as it is.
The method just below use a new style super() call so wee can assume that super(CBlock, self) is intentional.

Harbormaster completed remote builds in B14878: Diff 27140.Jan 20 2021, 16:56

Harbormaster completed remote builds in B14880: Diff 27142.Jan 20 2021, 17:12

majcosta accepted this revision.Jan 20 2021, 18:19

This revision is now accepted and ready to land.Jan 20 2021, 18:19

Closed by commit rABC438dca9e5035: test: use zero-argument super() shortcut (Python 3.0+) (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyJan 21 2021, 07:40

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC438dca9e5035: test: use zero-argument super() shortcut (Python 3.0+).