Differential D9031

[mempool] Don't throw expected error message when upgrading
ClosedPublic
Actions

Authored by PiRK on Jan 22 2021, 09:53.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0b9b237d2184: [mempool] Don't throw expected error message when upgrading

Summary

mempool.dat now contains unbroadcast transactions, that did not exist in
mempool.dat files created in previous version.
This commit prevent an uneccessary error message to be logged when users
update from v0.22.11 or lower.
The try..catch can be removed after everyone has upgraded to > v0.22.11.

This is a backport of Core PR18807 [4/9]
https://github.com/bitcoin/bitcoin/pull/18807/commits/9c8a55d9cb0ec73f10b196e79b637aa601c0a6b7

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 22 2021, 09:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2021, 09:53

PiRK requested review of this revision.Jan 22 2021, 09:53

teamcity edited the summary of this revision. (Show Details)Jan 22 2021, 09:53

Fabien accepted this revision.Jan 22 2021, 10:33

This revision is now accepted and ready to land.Jan 22 2021, 10:33

Harbormaster completed remote builds in B14941: Diff 27240.Jan 22 2021, 10:38

Closed by commit rABC0b9b237d2184: [mempool] Don't throw expected error message when upgrading (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyJan 22 2021, 11:01

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0b9b237d2184: [mempool] Don't throw expected error message when upgrading.

Revision Contents
Changeset List

Path

Size

src/

19 lines

Diff 27249

src/validation.cpp

Loading...