Differential D9090

[ci] enable second_deadlock_stack for TSan
ClosedPublic
Actions

Authored by majcosta on Jan 27 2021, 20:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCce2566d7e6fa: [ci] enable second_deadlock_stack for TSan

Summary

this gives us more informative error logs when TSan detects a lock inversion

Test Plan

invert a LOCK2(...) in a test somewhere

CC=clang CXX=clang++ cmake .. -GNinja -DENABLE_SANITIZERS=thread
ninja all check

make sure the TSan warning output is more informative

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 27 2021, 20:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 20:17

majcosta requested review of this revision.Jan 27 2021, 20:17

Harbormaster completed remote builds in B15024: Diff 27375.Jan 27 2021, 20:31

Fabien accepted this revision.Jan 28 2021, 09:27

This revision is now accepted and ready to land.Jan 28 2021, 09:27

Closed by commit rABCce2566d7e6fa: [ci] enable second_deadlock_stack for TSan (authored by majcosta). · Explain WhyJan 28 2021, 15:44

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCce2566d7e6fa: [ci] enable second_deadlock_stack for TSan.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

Sanitizers.cmake

1 line

Diff 27415

View Options

cmake/modules/Sanitizers.cmake

[ci] enable second_deadlock_stack for TSanClosedPublicActions