Differential D9092

[backport#18726] test: check misbehavior more independently in p2p_filter.py
ClosedPublic
Actions

Authored by majcosta on Jan 27 2021, 21:56.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa2a9c5790d5d: [backport#18726] test: check misbehavior more independently in p2p_filter.py

Summary

cd543d9193ac1882c1b4a8a84e3ac7356a8b7ce9 test: check misbehavior more independently in p2p_filter.py (Danny Lee)

Pull request description:

This expands on #18672 in two ways:

- Check positive cases (`filterload` accepted, `filteradd` accepted) in addition to the negative cases added in #18672
- Address MarcoFalke 's [suggestion](https://github.com/bitcoin/bitcoin/pull/18672#discussion_r412101752) to successfully load a filter before testing `filteradd`

Backport of Core PR18726

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jan 27 2021, 21:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 21:56

majcosta requested review of this revision.Jan 27 2021, 21:56

teamcity edited the summary of this revision. (Show Details)Jan 27 2021, 21:56

Harbormaster completed remote builds in B15026: Diff 27377.Jan 27 2021, 22:10

PiRK accepted this revision.Jan 28 2021, 07:01

This revision is now accepted and ready to land.Jan 28 2021, 07:01

Closed by commit rABCa2a9c5790d5d: [backport#18726] test: check misbehavior more independently in p2p_filter.py (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJan 28 2021, 14:11

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCa2a9c5790d5d: [backport#18726] test: check misbehavior more independently in p2p_filter.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

44 lines

Diff 27408

test/functional/p2p_filter.py

Loading...