[Cashtab] Remove mint artifact object of arrays style input
ClosedPublic
Actions

Authored by bytesofman on Feb 3 2021, 22:41.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCcc551892893d: [Cashtab] Remove mint artifact object of arrays style input

Summary

Limit the sendBch function to one address and one amount in units of BCHA. Refactor Send.js and tests to reflect new input style.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Feb 3 2021, 22:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 22:41

bytesofman requested review of this revision.Feb 3 2021, 22:41

Harbormaster completed remote builds in B15112: Diff 27526.Feb 3 2021, 22:44

renaming value to sendAmountInBcha is already conflicting with BCH and sendBCHMock. if we're going to change things, it should be renaming the latter as not to be coupled with ticker/brand acronyms, not the other way around, otherwise if the latter change it's gonna be really confusing.

majcosta requested changes to this revision.Feb 3 2021, 23:17

This revision now requires changes to proceed.Feb 3 2021, 23:17

Removing bcha-specific variable name

Harbormaster completed remote builds in B15119: Diff 27543.Feb 4 2021, 13:58

majcosta accepted this revision.Feb 4 2021, 14:34

This revision is now accepted and ready to land.Feb 4 2021, 14:34

Closed by commit rABCcc551892893d: [Cashtab] Remove mint artifact object of arrays style input (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyFeb 4 2021, 14:38

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCcc551892893d: [Cashtab] Remove mint artifact object of arrays style input.