Page MenuHomePhabricator

[Cashtab] Remove mint artifact object of arrays style input
ClosedPublic

Authored by josephroyking on Feb 3 2021, 22:41.

Details

Summary

Limit the sendBch function to one address and one amount in units of BCHA. Refactor Send.js and tests to reflect new input style.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

renaming value to sendAmountInBcha is already conflicting with BCH and sendBCHMock. if we're going to change things, it should be renaming the latter as not to be coupled with ticker/brand acronyms, not the other way around, otherwise if the latter change it's gonna be really confusing.

majcosta requested changes to this revision.Feb 3 2021, 23:17
This revision now requires changes to proceed.Feb 3 2021, 23:17

Removing bcha-specific variable name

This revision is now accepted and ready to land.Feb 4 2021, 14:34