Differential D9164

test: Remove global wait_until from p2p_getdata #
ClosedPublic
Actions

Authored by PiRK on Feb 4 2021, 09:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCeebe1aaf72ed: test: Remove global wait_until from p2p_getdata #

Summary

Using the global wait_until makes it impossible to adjust the timeout based on the hardware the test is running on.

Fix that by using the mininode member function.

This is a backport of Core PR19060

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 4 2021, 09:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2021, 09:25

PiRK requested review of this revision.Feb 4 2021, 09:25

teamcity edited the summary of this revision. (Show Details)Feb 4 2021, 09:25

Fabien accepted this revision.Feb 4 2021, 09:29

This revision is now accepted and ready to land.Feb 4 2021, 09:29

Harbormaster completed remote builds in B15117: Diff 27539.Feb 4 2021, 09:55

Closed by commit rABCeebe1aaf72ed: test: Remove global wait_until from p2p_getdata # (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyFeb 4 2021, 14:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCeebe1aaf72ed: test: Remove global wait_until from p2p_getdata #.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_getdata.py

19 lines

test_framework/

mininode.py

2 lines

Diff 27545

View Options

test/functional/p2p_getdata.py