Paths

Table of Contentst

Differential D9166

[Cashtab] Remove instance of toSatoshi from tx builder
ClosedPublic
Actions

Authored by josephroyking on Thu, Feb 4, 14:57.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC06496a4d8394: [Cashtab] Remove instance of toSatoshi from tx builder

Summary

Continuing the refactor of the sendBch function, remove the 2nd (of 3) instances of the toSatoshi function. Add unit tests to confirm that the new method is returning identical output to the old method.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

josephroyking created this revision.Thu, Feb 4, 14:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 4, 14:57

josephroyking requested review of this revision.Thu, Feb 4, 14:57

Harbormaster completed remote builds in B15120: Diff 27548.Thu, Feb 4, 15:00

majcosta accepted this revision.Thu, Feb 4, 15:34

This revision is now accepted and ready to land.Thu, Feb 4, 15:34

Closed by commit rABC06496a4d8394: [Cashtab] Remove instance of toSatoshi from tx builder (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyThu, Feb 4, 16:11

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABC06496a4d8394: [Cashtab] Remove instance of toSatoshi from tx builder.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

__tests__/

migrations.test.js

16 lines

useBCH.js

2 lines

Diff 27556

View Options

web/cashtab/src/hooks/tests/migrations.test.js

View Options

web/cashtab/src/hooks/useBCH.js

[Cashtab] Remove instance of toSatoshi from tx builderClosedPublicActions