Page MenuHomePhabricator
Differential D9181

Fix the deserialization of CoinEntry
ClosedPublic
Actions

Authored by Fabien on Fri, Feb 5, 21:14.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC05d6cf91570b: Fix the deserialization of CoinEntry
Summary

D9169 introduced new methods to make serialization/deserialization
easier to read and write, however the migration of CoinEntry is missing a VARINT() declaration and triggers a database corruption.

Test Plan
ninja all check-all

./src/bitcoind

Should return no database corruption.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, Feb 5, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 5, 21:14
Fabien requested review of this revision.Fri, Feb 5, 21:14
Fabien planned changes to this revision.Fri, Feb 5, 21:19
Fabien updated this revision to Diff 27590.Fri, Feb 5, 21:24
Fabien edited the summary of this revision. (Show Details)

Actually fix the issue

Harbormaster completed remote builds in B15141: Diff 27589.Fri, Feb 5, 21:28
Harbormaster completed remote builds in B15142: Diff 27590.Fri, Feb 5, 21:37
majcosta accepted this revision.Fri, Feb 5, 21:46
majcosta added a subscriber: majcosta.

tested locally, looks good

This revision is now accepted and ready to land.Fri, Feb 5, 21:46
Closed by commit rABC05d6cf91570b: Fix the deserialization of CoinEntry (authored by Fabien). · Explain WhyFri, Feb 5, 21:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC05d6cf91570b: Fix the deserialization of CoinEntry.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 27591

View Options

src/txdb.cpp

Loading...