Page MenuHomePhabricator

wallet: descriptor wallet cleanups
ClosedPublic

Authored by PiRK on Wed, Feb 17, 11:44.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCdaabc6926d49: wallet: descriptor wallet cleanups
Summary

rpc: createwallet warning that descriptor wallets are experimental

Remove unimplemented SetCrypted from DescriptorScriptPubKeyMan

Change SetType to SetInternal and remove m_address_type

m_address_type was used for two things:

  1. Determine the type of descriptor to generate during SetupDescriptorGeneration
  2. Sanity check during GetNewDestination.

There is no need to have this variable to accomplish those things.

  1. Add a argument to SetupDescriptorGeneration indicating the address type to use
  2. Use Descriptor::GetOutputType for the sanity check.

This is a backport of Core PR18787

It does not include the release notes from the original backport.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Wed, Feb 17, 11:45
PiRK retitled this revision from wallet: descriptor wallet release notes and cleanups to wallet: descriptor wallet cleanups.Thu, Feb 18, 07:05
majcosta requested changes to this revision.Fri, Feb 19, 17:30
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/wallet/scriptpubkeyman.cpp
1636–1640 ↗(On Diff #27717)

something fishy going on here

This revision now requires changes to proceed.Fri, Feb 19, 17:30

remove accidentaly duplicated line

This revision is now accepted and ready to land.Mon, Feb 22, 18:36
This revision was automatically updated to reflect the committed changes.