Page MenuHomePhabricator

test: Explain that a bug should be filed when the test fail
ClosedPublic

Authored by PiRK on Tue, Feb 23, 16:27.

Details

Summary

This is a backport of core#19110

Test Plan

i
Add an assert False to a test.
ninja && test/functional/test_runner.py abc-cmdline

Expected output:

2021-02-23T16:24:12.738000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-02-23T16:24:12.738000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-02-23T16:24:12.738000Z TestFramework (ERROR):

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Tue, Feb 23, 16:27

Tail of the build log:

[387/443] bitcoin: testing torcontrol_tests
[388/443] Running utility command for check-bitcoin-sigencoding_tests
[389/443] Running utility command for check-bitcoin-sync_tests
[390/443] Running utility command for check-bitcoin-torcontrol_tests
[391/443] bitcoin: testing wallet_crypto_tests
[392/443] bitcoin: testing scriptpubkeyman_tests
[393/443] bitcoin: testing streams_tests
[394/443] Running utility command for check-bitcoin-wallet_crypto_tests
[395/443] Running utility command for check-bitcoin-scriptpubkeyman_tests
[396/443] bitcoin: testing timedata_tests
[397/443] Running utility command for check-bitcoin-streams_tests
[398/443] Running utility command for check-bitcoin-timedata_tests
[399/443] bitcoin: testing undo_tests
[400/443] Running utility command for check-bitcoin-undo_tests
[401/443] bitcoin: testing uint256_tests
[402/443] Running utility command for check-bitcoin-uint256_tests
[403/443] bitcoin: testing script_standard_tests
[404/443] Running utility command for check-bitcoin-script_standard_tests
[405/443] bitcoin: testing blockcheck_tests
[406/443] bitcoin: testing radix_tests
[407/443] bitcoin: testing blockstatus_tests
[408/443] bitcoin: testing schnorr_tests
[409/443] Running utility command for check-bitcoin-blockcheck_tests
[410/443] Running utility command for check-bitcoin-radix_tests
[411/443] bitcoin: testing versionbits_tests
[412/443] Running utility command for check-bitcoin-blockstatus_tests
[413/443] Running utility command for check-bitcoin-schnorr_tests
[414/443] Running utility command for check-bitcoin-versionbits_tests
[415/443] bitcoin: testing validation_block_tests
[416/443] bitcoin: testing getarg_tests
[417/443] Running utility command for check-bitcoin-validation_block_tests
[418/443] bitcoin: testing cashaddr_tests
[419/443] Running utility command for check-bitcoin-getarg_tests
[420/443] Running utility command for check-bitcoin-cashaddr_tests
[421/443] bitcoin: testing script_tests
[422/443] Running utility command for check-bitcoin-script_tests
[423/443] bitcoin: testing wallet_tests
[424/443] bitcoin: testing validation_tests
[425/443] Running utility command for check-bitcoin-wallet_tests
[426/443] Running utility command for check-bitcoin-validation_tests
[427/443] bitcoin: testing cuckoocache_tests
[428/443] bitcoin: testing crypto_tests
[429/443] Running utility command for check-bitcoin-crypto_tests
[430/443] Running utility command for check-bitcoin-cuckoocache_tests
[431/443] bitcoin: testing monolith_opcodes_tests
[432/443] bitcoin: testing skiplist_tests
[433/443] bitcoin: testing coinselector_tests
FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,message:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no
Segmentation fault (core dumped)
[434/443] Running utility command for check-bitcoin-monolith_opcodes_tests
[435/443] Running utility command for check-bitcoin-skiplist_tests
[436/443] bitcoin: testing op_reversebytes_tests
[437/443] Running utility command for check-bitcoin-op_reversebytes_tests
[438/443] bitcoin: testing transaction_tests
[439/443] Running utility command for check-bitcoin-transaction_tests
[440/443] bitcoin: testing coins_tests
[441/443] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
This revision is now accepted and ready to land.Tue, Feb 23, 17:08