Page MenuHomePhabricator

[Cashtab] toggle display between tx history and tokens
ClosedPublic

Authored by josephroyking on Mon, Mar 22, 21:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0b2f82a91efb: [Cashtab] toggle display between tx history and tokens
Summary

Create custom tab pane components to display either TX history or tokens depending on user selection. Hide scroll bars (but do not disable scroll functionality) to prevent content jumping.

Test Plan

npm start ; toggle between "Transaction History" and "Tokens", observe smooth transition, orange line lines up with active label.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Better active pane underline css (previously did not line up in Firefox)

Fabien requested changes to this revision.Tue, Mar 23, 16:42
Fabien added a subscriber: Fabien.

arrow_tx_history.png (233×465 px, 15 KB)

Maybe I'm nit-picking but the arrow down icon is confusing. By clicking on it I expect the item to expand with details, but it opens the explorer in a new window. Can this icon be chosen to not look like an expand/collapse button ?

This revision now requires changes to proceed.Tue, Mar 23, 16:42

Less ambiguous send/receive icons

This revision is now accepted and ready to land.Wed, Mar 24, 07:32