Page MenuHomePhabricator

[Cashtab] Parse token txs in tx history
ClosedPublic

Authored by josephroyking on Wed, Mar 24, 19:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4ae0093b9d1b: [Cashtab] Parse token txs in tx history
Summary

Parse and render information about token transctions for tx history

Test Plan

npm start, observe token txs in tx history, check at different widths for responsiveness, confirm rendered info matches explorer output by clicking the tx to view at explorer.be.cash

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Fri, Mar 26, 19:22
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/cashtab/src/hooks/useBCH.js
197 ↗(On Diff #28012)

remove

207 ↗(On Diff #28012)

The token parsing deserves some unit tests

web/cashtab/src/hooks/useWallet.js
203 ↗(On Diff #28012)

dito

205 ↗(On Diff #28012)

dito

This revision now requires changes to proceed.Fri, Mar 26, 19:22
josephroyking marked 3 inline comments as done.

Add unit tests with mocks for parsing token txs, limit rendered tx count to 5 (api load evident in testing), set rendered tx count as a parameter in Ticker.js

This revision is now accepted and ready to land.Sat, Mar 27, 15:50