Differential D9352

[avalanche] Move the utxo limitation to the proof verification
ClosedPublic
Actions

Authored by Fabien on Mar 26 2021, 15:15.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC21cb6fe9e03e: [avalanche] Move the utxo limitation to the proof verification

Summary

This makes it possible to build a proof with too many utxos, but clean
the network layer from this verification.

Test Plan

./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 26 2021, 15:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2021, 15:15

Fabien requested review of this revision.Mar 26 2021, 15:15

Fabien added a child revision: D9353: [avalanche] Add an RPC to build a delegation.Mar 26 2021, 15:22

Harbormaster completed remote builds in B15414: Diff 28028.Mar 26 2021, 15:27

PiRK added a subscriber: PiRK.Mar 26 2021, 16:40

PiRK added inline comments.

test/functional/abc_rpc_avalancheproof.py
22 ↗	(On Diff #28028)	this function is now unused
86 ↗	(On Diff #28028)	I think this removes the only functional test we currently have adding a node with a good multiple UTXOs proof .

PiRK requested changes to this revision.Mar 26 2021, 16:40

This revision now requires changes to proceed.Mar 26 2021, 16:40

PiRK added inline comments.Mar 26 2021, 16:44

test/functional/abc_rpc_avalancheproof.py
86 ↗	(On Diff #28028)	The test wasn't good anyway, because it was missing an assert to check that addavalanchenode returns True. But we have to remember to add another one in a future diff.

Reintroduce and fix the test for addavalanchenode

PiRK accepted this revision.Mar 26 2021, 17:27

This revision is now accepted and ready to land.Mar 26 2021, 17:27

Harbormaster completed remote builds in B15417: Diff 28031.Mar 26 2021, 17:54

Closed by commit rABC21cb6fe9e03e: [avalanche] Move the utxo limitation to the proof verification (authored by Fabien). · Explain WhyMar 26 2021, 19:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC21cb6fe9e03e: [avalanche] Move the utxo limitation to the proof verification.

Fabien removed a child revision: D9353: [avalanche] Add an RPC to build a delegation.Mar 26 2021, 19:07

Revision Contents
Changeset List

Path

Size

src/

avalanche/

5 lines

5 lines

4 lines

1 line

5 lines

net_processing.cpp

6 lines

rpc/

5 lines

test/

functional/

abc_rpc_avalancheproof.py

25 lines

Diff 28033

src/avalanche/processor.h

Loading...

src/avalanche/proof.h

Loading...

src/avalanche/proof.cpp

Loading...

src/avalanche/validation.h

Loading...

src/init.cpp

Loading...

src/net_processing.cpp

Loading...

src/rpc/avalanche.cpp

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...