Page MenuHomePhabricator

[avalanche] Move the utxo limitation to the proof verification
ClosedPublic

Authored by Fabien on Fri, Mar 26, 15:15.

Details

Summary

This makes it possible to build a proof with too many utxos, but clean
the network layer from this verification.

Test Plan
./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Fri, Mar 26, 15:15
PiRK added inline comments.
test/functional/abc_rpc_avalancheproof.py
22 ↗(On Diff #28028)

this function is now unused

86 ↗(On Diff #28028)

I think this removes the only functional test we currently have adding a node with a good multiple UTXOs proof .

PiRK requested changes to this revision.Fri, Mar 26, 16:40
This revision now requires changes to proceed.Fri, Mar 26, 16:40
test/functional/abc_rpc_avalancheproof.py
86 ↗(On Diff #28028)

The test wasn't good anyway, because it was missing an assert to check that addavalanchenode returns True. But we have to remember to add another one in a future diff.

Reintroduce and fix the test for addavalanchenode

This revision is now accepted and ready to land.Fri, Mar 26, 17:27