Paths

Table of Contentst

Differential D9362

[Cashtab] Exclude slp utxos if tokenQty is 0
ClosedPublic
Actions

Authored by bytesofman on Mar 30 2021, 19:42.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa89ca0947a1d: [Cashtab] Exclude slp utxos if tokenQty is 0

Summary

If an slp utxo is returned with tokenQty === '0', it should not be included in the app's token utxo set. This diff adds this rule and a new unit test confirming it.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mar 30 2021, 19:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2021, 19:42

bytesofman requested review of this revision.Mar 30 2021, 19:42

Harbormaster completed remote builds in B15430: Diff 28051.Mar 30 2021, 19:45

Fabien accepted this revision.Mar 31 2021, 06:13

This revision is now accepted and ready to land.Mar 31 2021, 06:13

Fabien mentioned this in D9359: [Cashtab] Add latest features to browser extension.Mar 31 2021, 06:22

Closed by commit rABCa89ca0947a1d: [Cashtab] Exclude slp utxos if tokenQty is 0 (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyMar 31 2021, 13:14

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCa89ca0947a1d: [Cashtab] Exclude slp utxos if tokenQty is 0.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

__mocks__/

mockReturnGetHydratedUtxoDetailsWithZeroBalance.js

761 lines

mockReturnGetSlpBalancesAndUtxosNoZeroBalance.js

733 lines

__tests__/

useBCH.test.js

14 lines

useBCH.js

7 lines

Diff 28060

View Options

web/cashtab/src/hooks/mocks/mockReturnGetHydratedUtxoDetailsWithZeroBalance.js

View Options

web/cashtab/src/hooks/mocks/mockReturnGetSlpBalancesAndUtxosNoZeroBalance.js

View Options

web/cashtab/src/hooks/tests/useBCH.test.js

View Options

web/cashtab/src/hooks/useBCH.js

[Cashtab] Exclude slp utxos if tokenQty is 0ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28060

web/cashtab/src/hooks/__mocks__/mockReturnGetHydratedUtxoDetailsWithZeroBalance.js

web/cashtab/src/hooks/__mocks__/mockReturnGetSlpBalancesAndUtxosNoZeroBalance.js

web/cashtab/src/hooks/__tests__/useBCH.test.js

web/cashtab/src/hooks/useBCH.js

[Cashtab] Exclude slp utxos if tokenQty is 0
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/hooks/mocks/mockReturnGetHydratedUtxoDetailsWithZeroBalance.js

web/cashtab/src/hooks/mocks/mockReturnGetSlpBalancesAndUtxosNoZeroBalance.js

web/cashtab/src/hooks/tests/useBCH.test.js