Differential D9381

[SECP256K1] Extract the secret key from a keypair
ClosedPublic
Actions

Authored by Fabien on Apr 8 2021, 11:33.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC01ee0628117a: [SECP256K1] Extract the secret key from a keypair

Summary

With schnorrsig if you need to tweak the secret key (for BIP32) you must
use the keypair API to get compatible secret/public keys which you do by
calling secp256k1_keypair_xonly_tweak_add(), but after that there's no
currently a way to extract the secret key back for storage.
so I added a secp256k1_keypair_seckey function to extract the key

Backport of secp256k1#845

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 8 2021, 11:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2021, 11:33

Fabien requested review of this revision.Apr 8 2021, 11:33

teamcity edited the summary of this revision. (Show Details)Apr 8 2021, 11:33

Harbormaster completed remote builds in B15464: Diff 28097.Apr 8 2021, 11:46

deadalnix accepted this revision.Apr 8 2021, 13:04

This revision is now accepted and ready to land.Apr 8 2021, 13:04

Closed by commit rABC01ee0628117a: [SECP256K1] Extract the secret key from a keypair (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by Fabien). · Explain WhyApr 8 2021, 13:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC01ee0628117a: [SECP256K1] Extract the secret key from a keypair.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

include/

secp256k1_extrakeys.h

13 lines

src/

modules/

extrakeys/

10 lines

27 lines

valgrind_ctime_test.c

6 lines

Diff 28108

src/secp256k1/include/secp256k1_extrakeys.h

Loading...

src/secp256k1/src/modules/extrakeys/main_impl.h

Loading...

src/secp256k1/src/modules/extrakeys/tests_impl.h

Loading...

src/secp256k1/src/valgrind_ctime_test.c

Loading...