Page MenuHomePhabricator

[avalanche] Fail to delegate to self
Needs RevisionPublic

Authored by Fabien on Wed, Apr 28, 19:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

The addLevel() method should fail when attempting to delegate to the
same pubkey, since no delegation level is actually added.

Test Plan
ninja check-functional

Diff Detail

Event Timeline

Fabien requested review of this revision.Wed, Apr 28, 19:37
deadalnix requested changes to this revision.Thu, Apr 29, 11:56
deadalnix added a subscriber: deadalnix.

I don't see any reason this patch should exists, and the description provides none.

src/avalanche/delegationbuilder.cpp
43

I don't think this is solving any problem, just adding special cases.

test/functional/abc_rpc_avalancheproof.py
226

Why should this be an error?

This revision now requires changes to proceed.Thu, Apr 29, 11:56