Page MenuHomePhabricator
Differential D9454

[avalanche] Fail to delegate to self
AbandonedPublic
Actions

Authored by Fabien on Apr 28 2021, 19:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

The addLevel() method should fail when attempting to delegate to the
same pubkey, since no delegation level is actually added.

Test Plan
ninja check-functional

Diff Detail

Event Timeline

Fabien created this revision.Apr 28 2021, 19:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2021, 19:37
Fabien requested review of this revision.Apr 28 2021, 19:37
Harbormaster completed remote builds in B15595: Diff 28297.Apr 28 2021, 19:51
deadalnix requested changes to this revision.Apr 29 2021, 11:56
deadalnix added a subscriber: deadalnix.

I don't see any reason this patch should exists, and the description provides none.

src/avalanche/delegationbuilder.cpp
43

I don't think this is solving any problem, just adding special cases.

test/functional/abc_rpc_avalancheproof.py
226

Why should this be an error?

This revision now requires changes to proceed.Apr 29 2021, 11:56
Fabien abandoned this revision.Jun 4 2021, 20:00

Revision Contents
Changeset List

PathSize
src/
avalanche/
6 lines
5 lines
test/
functional/
19 lines

Diff 28297

View Options

src/avalanche/delegationbuilder.cpp

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

test/functional/abc_rpc_avalancheproof.py

Loading...