Page MenuHomePhabricator

[Cashtab] update @zxing/library
Changes PlannedPublic

Authored by majcosta on Fri, Apr 30, 16:43.

Details

Reviewers
josephroyking
Group Reviewers
Restricted Project
Summary

current version uses out-of-date @zxing/library (for QR code display)
and this version was pulling an unmaintained text-encoding dependency

they seem to have forked text-encoding into @zxing/text-encoding and are
maintaining it themselves

Test Plan
npm install --package-lock-only && npm ci
npm start

opened a fresh wallet, and sent BCHA and tokens to it by scanning the
displayed QR codes with my phone which runs the production version of
cashtab

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update_zxing_library
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15608
Build 31132: Build Diffcashtab-tests
Build 31131: arc lint + arc unit